Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macros/CSSRef): include level two functions #10679

Merged
merged 6 commits into from Apr 16, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Mar 12, 2024

@estelle reported that CSS functions that are deeper in files/en-us/web/css tree are not getting rendered in the sidebar.

Solution

Include the docs at level 2 as well. At level 3 there are only z-index guide example pages. There is no level 4.
After the change, 61 new functions are getting added to the sidebar. Following is the HTML code that gets added:

Added HTML Code
<li><a href="/en-US/docs/Web/CSS/animation-timeline/scroll">scroll()</a><abbr
                            class="icon icon-experimental"
                            title="Experimental. Expect behavior to change in the future.">
                            <span class="visually-hidden">Experimental</span>
                        </abbr></li>
                    <li><a href="/en-US/docs/Web/CSS/animation-timeline/view">view()</a><abbr
                            class="icon icon-experimental"
                            title="Experimental. Expect behavior to change in the future.">
                            <span class="visually-hidden">Experimental</span>
                        </abbr></li>
                    <li><a href="/en-US/docs/Web/CSS/basic-shape/circle">circle()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/basic-shape/ellipse">ellipse()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/basic-shape/inset">inset()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/basic-shape/polygon">polygon()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/basic-shape/rect">rect()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/basic-shape/xywh">xywh()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/color_value/color">color()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/color_value/color-contrast">color-contrast()</a><abbr
                            class="icon icon-experimental"
                            title="Experimental. Expect behavior to change in the future.">
                            <span class="visually-hidden">Experimental</span>
                        </abbr></li>
                    <li><a href="/en-US/docs/Web/CSS/color_value/color-mix">color-mix()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/color_value/device-cmyk">device-cmyk()</a></li>
                    <li><em><a href="/en-US/docs/Web/CSS/color_value/hsl" aria-current="page">hsl()</a></em></li>
                    <li><a href="/en-US/docs/Web/CSS/color_value/hwb">hwb()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/color_value/lab">lab()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/color_value/lch">lch()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/color_value/light-dark">light-dark()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/color_value/oklab">oklab()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/color_value/oklch">oklch()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/color_value/rgb">rgb()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/filter-function/blur">blur()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/filter-function/brightness">brightness()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/filter-function/contrast">contrast()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/filter-function/drop-shadow">drop-shadow()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/filter-function/grayscale">grayscale()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/filter-function/hue-rotate">hue-rotate()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/filter-function/invert">invert()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/filter-function/opacity">opacity()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/filter-function/saturate">saturate()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/filter-function/sepia">sepia()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/font-palette/palette-mix">palette-mix()</a><abbr
                            class="icon icon-experimental"
                            title="Experimental. Expect behavior to change in the future.">
                            <span class="visually-hidden">Experimental</span>
                        </abbr></li>
                    <li><a href="/en-US/docs/Web/CSS/gradient/conic-gradient">conic-gradient()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/gradient/linear-gradient">linear-gradient()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/gradient/radial-gradient">radial-gradient()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/gradient/repeating-conic-gradient">repeating-conic-gradient()</a>
                    </li>
                    <li><a href="/en-US/docs/Web/CSS/gradient/repeating-linear-gradient">repeating-linear-gradient()</a>
                    </li>
                    <li><a href="/en-US/docs/Web/CSS/gradient/repeating-radial-gradient">repeating-radial-gradient()</a>
                    </li>
                    <li><a href="/en-US/docs/Web/CSS/image/image">image()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/image/image-set">image-set()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/image/paint">paint()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/matrix">matrix()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/matrix3d">matrix3d()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/perspective">perspective()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/rotate">rotate()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/rotate3d">rotate3d()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/rotateX">rotateX()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/rotateY">rotateY()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/rotateZ">rotateZ()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/scale">scale()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/scale3d">scale3d()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/scaleX">scaleX()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/scaleY">scaleY()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/scaleZ">scaleZ()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/skew">skew()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/skewX">skewX()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/skewY">skewY()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/translate">translate()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/translate3d">translate3d()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/translateX">translateX()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/translateY">translateY()</a></li>
                    <li><a href="/en-US/docs/Web/CSS/transform-function/translateZ">translateZ()</a></li>

Screenshots

Before

1

After

2

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner March 12, 2024 10:18
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Mar 12, 2024
@estelle
Copy link
Member

estelle commented Mar 12, 2024

Thank you @OnkarRuikar.

similar issue: #8755

fixes #10731

@caugner caugner changed the title fix(macro): include level two functions in CSSRef macro fix(macros/CSSRef): include level two functions Mar 28, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTU (@argl @fiji-flo @caugner), just some comments.

kumascript/macros/CSSRef.ejs Outdated Show resolved Hide resolved
kumascript/macros/CSSRef.ejs Outdated Show resolved Hide resolved
kumascript/macros/CSSRef.ejs Outdated Show resolved Hide resolved
kumascript/macros/CSSRef.ejs Outdated Show resolved Hide resolved
OnkarRuikar and others added 2 commits March 29, 2024 13:49
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
@caugner caugner merged commit cd7458c into mdn:main Apr 16, 2024
10 checks passed
@OnkarRuikar OnkarRuikar deleted the update_cssref_macro branch April 17, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Sidebar: many functions are not listed
3 participants