Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/HTTPSidebar): improve Spanish locale #10710

Merged
merged 6 commits into from Mar 20, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Mar 15, 2024

Summary

Problem

Some elements in the spanish version of MDN website's sidebar contain typos, mistranslations or are outright missing a translation.

Solution

Fixed the typos and corrected some translations.


Screenshots

Before

Screenshot 2024-03-15 at 2 18 52 p m

How did you test this change?

@edgarrmondragon edgarrmondragon requested a review from a team as a code owner March 15, 2024 01:02
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Mar 15, 2024
@edgarrmondragon edgarrmondragon changed the title Fix a few Spanish typos and mistranslations in the sidebar chore: Fix a few Spanish typos and mistranslations in the sidebar Mar 15, 2024
@caugner caugner requested review from a team and marcelozarate and removed request for a team March 15, 2024 11:09
@caugner
Copy link
Contributor

caugner commented Mar 15, 2024

Hi @edgarrmondragon, thank you for opening this PR. 👋

Please take a moment to fill out the sections in the PR description (you can remove the Screenshots) section. 🙏

@edgarrmondragon
Copy link
Contributor Author

Hi @edgarrmondragon, thank you for opening this PR. 👋

Please take a moment to fill out the sections in the PR description (you can remove the Screenshots) section. 🙏

@caugner Done!

@caugner caugner changed the title chore: Fix a few Spanish typos and mistranslations in the sidebar chore(macros/HTTPSidebar): improve Spanish locale Mar 18, 2024
Copy link
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edgarrmondragon thank you for adding these fixes :shipit:

@JuanVqz
Copy link
Member

JuanVqz commented Mar 18, 2024

I don't have enough permissions to approve the remaining workflows, as for Spanish translation, this looks right to be merged!

@caugner caugner merged commit 8ac8c6f into mdn:main Mar 20, 2024
10 checks passed
@caugner
Copy link
Contributor

caugner commented Mar 20, 2024

Thanks @edgarrmondragon for the PR and @JuanVqz for the review! 🙌

@edgarrmondragon edgarrmondragon deleted the sidebar-spanish-typos branch March 20, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants