Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidebar-filter): measure when user types in the filter #10912

Merged
merged 2 commits into from Apr 15, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 15, 2024

Summary

(MP-1007)

Problem

We measure when users focus the sidebar filter, but we don't measure when users type in it.

Solution

Add a measurement on the first type.


How did you test this change?

Ran yarn && yarn dev with Glean debugging enabled (REACT_APP_GLEAN_CHANNEL, REACT_APP_GLEAN_DEBUG and REACT_APP_GLEAN_ENABLED).

  1. Opened http://localhost:3000/en-US/docs/Learn/HTML
  2. Focused the sidebar filter (and observed the sidebar_filter_focus measurement).
  3. Started typing (and observed a single instance of the new sidebar_filter_typed measurement).
  4. Unfocused, focused again and continued typing (without observing any measurement).
  5. Cleared the sidebar filter, focused again (and observed another sidebar_filter_focus measurement).
  6. Started typing again (and observed another sidebar_filter_typed measurement).

@caugner caugner requested a review from a team as a code owner April 15, 2024 10:03
@caugner caugner marked this pull request as draft April 15, 2024 10:03
@caugner caugner force-pushed the MP-1007-measure-sidebar-filter-typed branch from c73fa75 to 48c02a0 Compare April 15, 2024 12:52
@caugner caugner marked this pull request as ready for review April 15, 2024 13:42
@caugner caugner merged commit 26ed0e5 into main Apr 15, 2024
15 checks passed
@caugner caugner deleted the MP-1007-measure-sidebar-filter-typed branch April 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants