-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use deprecation flag from BCD #2138
Comments
I did not understand if you intend to pass the data in query string from the links of the BCD to the next page or fetching 2 times the data of the BCD, 1 time for the page and 1 time for the table. But does the BCD have any services? Where does the data come from? |
It's from: Line 33 in dc823a0
|
Intresting issue for do matching things, keys, address in JSON from location of HTML. So... Should be intresting a little Status
See JSON file that contains this object of this table on GitHub |
I'd rather keep the current design.
|
Ok. |
Yes, it's fairly straightforward. Say the URI is Edit: Maybe this should be a macro like |
I like to rename things. However, I think that by referring to the page some function should return the JSON file and then from there export either the initial div with the status or the BCD in order not to replicate the logic of the mapping between repositories. I also think about additional services on the feature URL that return fractions of JSON. API/Foo/Bar/status > returns an object In any case I can't put comments on the Kumascript linked macro but only on the PRs. Does BCT data be deployed as is so I can use |
You mean something like this? 👀 https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/drawWidgetAsOnScreen/bcd.json |
Questionable because we see that it was born for compatibility ( I imagine something similar but slightly revised to represent the page and therefore also the support table as a child of a big feature object. Feature.method()Status... a table from an object ... Content... Support... a table from an object ... |
Could this data pass via some https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta |
I think fetching twice is okay as the response will be cached. |
Draft of a PR// We are in some lifecyle hook
fetch(Object.assign(new URL("https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/drawWidgetAsOnScreen/bcd.json"), {
// Something known in the global scope like properties from an URL object constructed from location
})
.then(response=>response.json())
.then(body=>{
// Todo update the state of the component with the status Key and some if statments here or in the template
this.status = body.status // Is here or more in depth?
}) This should be done in the Component or at App level and passed down via props. (I can't PR or assign this issue to me just comment, I'm sorry). |
@ddbeck Thoughts? Close? |
@schalkneethling There's a bit to unpack here. This discussion captures some of the issues involved: https://github.com/mdn/content/discussions/5549. That said, the underlying idea—drive this stuff from BCD—is a good idea. But there's two distinct tasks that would come from this:
Not sure if we should open separate issues, hijack this one, or what. Also related: #1400 (comment) |
@ddbeck Almost sounds like creating 2 separate issues with a clear definition of work makes more sense. We can the prioritise them along with all of the other items we have. Not sure who the best person is to create those but, I have a suspicion it might be you 😄 |
Closing in favor of duplicate #3929. |
Currently MDN has a separate deprecation tag and the header. Could it use the
deprecated
flag from BCD and autogenerate such header, so that there won't be two separate source of truth?(BTW, is the Deprecated tag still a thing in Yari? I don't see it rendered anywhere, except the header.)
The text was updated successfully, but these errors were encountered: