Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Embedded iframe styling issues in dark mode #5436

Closed
cherrol opened this issue Mar 3, 2022 · 3 comments
Closed

Bug: Embedded iframe styling issues in dark mode #5436

cherrol opened this issue Mar 3, 2022 · 3 comments
Labels
interactive-examples issues related to interactive examples (EmbedInteractiveExample macro) redesign issues related to the new design

Comments

@cherrol
Copy link

cherrol commented Mar 3, 2022

It is recommended to set the iframe background color to white to keep access in dark mode.
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 3, 2022
@sideshowbarker sideshowbarker added infra and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. Opportunity assessment labels Mar 3, 2022
@sideshowbarker
Copy link
Collaborator

@mdn/core-yari-content

@sideshowbarker sideshowbarker transferred this issue from mdn/content Mar 3, 2022
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 3, 2022
@schalkneethling schalkneethling added redesign issues related to the new design interactive-examples issues related to interactive examples (EmbedInteractiveExample macro) and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. infra labels Mar 3, 2022
@caugner
Copy link
Contributor

caugner commented Mar 3, 2022

Hi @cherrol, thank you for taking the time to report this. 👋

Would you mind verifying if #5428 covers the issue you're having?

@caugner caugner changed the title Embedded iframe styling issues in dark mode Bug: Embedded iframe styling issues in dark mode Mar 3, 2022
@cherrol
Copy link
Author

cherrol commented Mar 4, 2022

嗨@cherrol，感谢您抽出宝贵时间报告此问题。👋

您介意验证#5428是否涵盖您遇到的问题吗？

Looks like the same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interactive-examples issues related to interactive examples (EmbedInteractiveExample macro) redesign issues related to the new design
Projects
Yari Platform Engineering
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sideshowbarker @caugner @schalkneethling @cherrol