Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: specify that the RPC endpoint is HTTP/S #17

Closed
onbjerg opened this issue Mar 30, 2022 · 5 comments
Closed

docs: specify that the RPC endpoint is HTTP/S #17

onbjerg opened this issue Mar 30, 2022 · 5 comments

Comments

@onbjerg
Copy link

onbjerg commented Mar 30, 2022

When foundry-rs/foundry#1003 is merged Forge will support WebSocket and IPC endpoints which should (in theory, at least) significantly speed up forking, since instead of closing and re-opening the RPC at every request, we would keep the connection alive.

As a sidenote, would it make sense to try and compare with a WebSocket endpoint as well? IPC might be a bit too much.

@mds1
Copy link
Owner

mds1 commented Mar 30, 2022

If we just change the below bullet to this, do you think that would be sufficient?

- - "Remote RPC" benchmarks used Alchemy as the RPC provider.
+ - "Remote RPC" benchmarks used Alchemy as the RPC provider, connected over HTTPS.

I am curious to see how performance compares between websockets and HTTPS. I'm not sure offhand if ganache and hardhat support it, but if so maybe we can add a second benchmark comparing those three over websockets?

@onbjerg
Copy link
Author

onbjerg commented Mar 30, 2022

Yeah, that's fine.

And yeah, I agree - if they support it, we should benchmark and compare. Otherwise, it's probably not a fair comparison 😄

@mds1
Copy link
Owner

mds1 commented Mar 30, 2022

Just pushed 2b13971 which updates the docs, created #18 to track websocket benchmarks investigation/support!

@mds1 mds1 closed this as completed Mar 30, 2022
@mds1
Copy link
Owner

mds1 commented Mar 30, 2022

Forgot to address IPC: I don't think I've ever come across any real usage/support of IPC either from dev framework or node operators like Infura and Alchemy. (I've also never really looked for it, so I could be wrong). But given that, it doesn't seem worth considering here

@meetmangukiya
Copy link

Yeah, I don't think IPC is usable out of local fs. So node operators likely won't have any such support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants