Skip to content
This repository has been archived by the owner on Apr 11, 2019. It is now read-only.

constructor parameters for ZipkinClient? #89

Closed
hakanson opened this issue Jul 27, 2016 · 2 comments
Closed

constructor parameters for ZipkinClient? #89

hakanson opened this issue Jul 27, 2016 · 2 comments

Comments

@hakanson
Copy link
Contributor

From the README.md, it looks like just IOwinContext

var client = new ZipkinClient(context);

but Medidata.ZipkinTracer.Core (v3.0.0) from NuGet (as of 26 July 2016), it takes 3 required and 1 optional parameters

public ZipkinClient(ILog logger, IZipkinConfig zipkinConfig, IOwinContext context, SpanCollector collector = null);

and ZipkinClient.cs takes 2 required and 1 optional parameters

public ZipkinClient(IZipkinConfig zipkinConfig, IOwinContext context, SpanCollector collector = null)

Assuming the current source is correct, it looks like both the README and NuGet need to be updated.

@bvillanueva-mdsol
Copy link
Contributor

Thanks @hakanson for raising these inconsistencies. I'm brewing up a PR to correct the readme and update the nuget within today. I'll update once it is done. Thanks!

@bvillanueva-mdsol
Copy link
Contributor

We updated recently the readme and nuget. I hope it addressed the issue. @hakanson, can you confirm and close this issue? Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants