Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please remove totally outdated and unmaintained mdx.maco #1388

Closed
thediveo opened this issue Dec 16, 2020 · 7 comments
Closed

please remove totally outdated and unmaintained mdx.maco #1388

thediveo opened this issue Dec 16, 2020 · 7 comments
Labels
📚 area/docs This affects documentation 👯 no/duplicate Déjà vu

Comments

@thediveo
Copy link

Subject of the issue

The official mdx-js documentation requests to install mdx.macro along create-react-app. However, mdx.macro has unmaintained and totally outdated mdx-js dependencies to version <1.0.0. The result is that several documented functions of 1.x+ do not work. It took me quite some time to figure this out. Unfortunately, the author of mdx.macro is unable to upgrade the dependencies. When trying to manually overriding the outdated dependencies, the generated MDX code doesn't work due to changes in the API before and after 1.0+.

Your environment

  • OS: Ubuntu 20.04

Steps to reproduce

yarn install mdx.macro

Expected behaviour

Currently documented mdx features, such as inline components, to work.

Actual behaviour

Currently documented mdx features, such as inline components, don't work.

@thediveo thediveo added 🐛 type/bug This is a problem 🙉 open/needs-info This needs some more info labels Dec 16, 2020
@ChristianMurphy
Copy link
Member

this is in progress at #589, if you want to do the finishing touches on the docs, a follow up PR would be welcome

@ChristianMurphy ChristianMurphy added good first issue 👋 This may be a great place to get started! help wanted 🙏 This could use your insight or help 📚 area/docs This affects documentation and removed 🐛 type/bug This is a problem 🙉 open/needs-info This needs some more info labels Dec 16, 2020
@ChristianMurphy
Copy link
Member

this is a duplicate of #365, closing this issue to consolidate the conversation over there.

@thediveo
Copy link
Author

thediveo commented Dec 16, 2020

I'm stuck because that PR example doesn't work for me when applied to my cra project:

Unexpected '!' in '!babel-loader!mdx-loader!./About.mdx'. Do not use import syntax to configure webpack loaders  import/no-webpack-loader-syntax

@ChristianMurphy
Copy link
Member

The message you shared is a lint warning, not a webpack error.
So it may be, and probably is, working?

@thediveo
Copy link
Author

It classifies as "Failed to compile" ... that's not looking like a linting issue.

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Dec 16, 2020

Following up on

closing this issue to consolidate the conversation over there.

Can we please have the conversation at #365 instead of both here and there?

@thediveo

This comment has been minimized.

@mdx-js mdx-js locked and limited conversation to collaborators Dec 16, 2020
@wooorm wooorm removed good first issue 👋 This may be a great place to get started! help wanted 🙏 This could use your insight or help labels Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📚 area/docs This affects documentation 👯 no/duplicate Déjà vu
Development

No branches or pull requests

3 participants