Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Use create-react-context for 16.0+ compatibility #178

Closed
mAAdhaTTah opened this issue Jul 5, 2018 · 4 comments
Closed

Suggestion: Use create-react-context for 16.0+ compatibility #178

mAAdhaTTah opened this issue Jul 5, 2018 · 4 comments

Comments

@mAAdhaTTah
Copy link
Contributor

mAAdhaTTah commented Jul 5, 2018

Currently, mdx-tag requires React 16.3+. I believe this is mostly due to the user of the new createContext, a feature landed in React 16.3. For my project, I need to use React 16.2 because Enzyme, the testing library I'm using, doesn't yet support the new features added in 16.3, so I'm using React 16.2 in my project to run my tests.

If mdx swapped out its usage of createContext for the create-react-context library, I'd be able to continue to use 16.2 in my tests.

I'd also be willing to do this work, if this is something you'd accept.

@johno
Copy link
Member

johno commented Jul 5, 2018

It makes sense to support all React v16 since it looks like a pretty trivial change, I'd gladly accept a PR to use create-react-context.

@mAAdhaTTah
Copy link
Contributor Author

Opened PR #179 for this.

@johno johno closed this as completed in #179 Jul 6, 2018
@johno
Copy link
Member

johno commented Jul 6, 2018

Published a prerelease with these changes, 0.13.1-0. Please let me know if you encounter any issues.

@mAAdhaTTah
Copy link
Contributor Author

No issues, this works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants