Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade documentation site Vercel instance to use node 16 #2235

Closed
4 tasks done
ChristianMurphy opened this issue Jan 24, 2023 · 2 comments
Closed
4 tasks done

Upgrade documentation site Vercel instance to use node 16 #2235

ChristianMurphy opened this issue Jan 24, 2023 · 2 comments
Labels
🏗 area/tools This affects tooling 🕸 area/website This affects the website 💪 phase/solved Post is done

Comments

@ChristianMurphy
Copy link
Member

Initial checklist

Problem

Currently several dependencies are locked in place due to Vercel/Lambda previously only supporting up to Node.js 14

mdx/renovate.json5

Lines 13 to 15 in f4d78be

// `node-loader@2` depends on Node 16+. Our website is on Vercel/AWS which don’t support Node 16.
'@node-loader/babel',
'@node-loader/core'

However now Node.js 16 is available, and those could be unlocked https://vercel.com/changelog/node-js-16-lts-is-now-available

Solution

A maintainer with access to the Vercel site changing the setting for Node.js version

Alternatives

Leaving the dependencies and the site locked at Node 14

@wooorm
Copy link
Member

wooorm commented Jan 24, 2023

Site currently doesn’t build on v16 because the alpha react server components build needs Node v14 loaders.
And the RSC version that was shipped in React 18 is different from the one this site is built on

@ChristianMurphy ChristianMurphy added 🏗 area/tools This affects tooling 🕸 area/website This affects the website labels Sep 22, 2023
@wooorm
Copy link
Member

wooorm commented Oct 18, 2023

This is now done!

@wooorm wooorm closed this as completed Oct 18, 2023
@wooorm wooorm added the 💪 phase/solved Post is done label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗 area/tools This affects tooling 🕸 area/website This affects the website 💪 phase/solved Post is done
Development

No branches or pull requests

2 participants