Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singletons in ContextContainer have unclear scoping #187

Open
meadsteve opened this issue Dec 1, 2021 · 0 comments
Open

Singletons in ContextContainer have unclear scoping #187

meadsteve opened this issue Dec 1, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@meadsteve
Copy link
Owner

For the ContextContainer the resolved instance will persist in the singleton even after exit has been called. This doesn't really make sense.

It's only an issue in the ContextContainer itself not the fastapi integration as the fastapi integration has one container per request and no re-use.

@meadsteve meadsteve added the bug Something isn't working label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant