Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.0.0b] [Task] - Improve Recipe Printing #1082

Closed
hay-kot opened this issue Mar 21, 2022 · 4 comments · Fixed by #1351
Closed

[v1.0.0b] [Task] - Improve Recipe Printing #1082

hay-kot opened this issue Mar 21, 2022 · 4 comments · Fixed by #1351
Labels
good first issue Good for newcomers task General Task that needs to be completed v1 Version 1 Issue/PR
Milestone

Comments

@hay-kot
Copy link
Collaborator

hay-kot commented Mar 21, 2022

What is the problem this task addresses?

Printing a Recipe in mealie is half-baked at best. Some information is unavailable, and the formatting can be inconsistent.

Proposed/Possible Solution(s)?

Mealie should implementing a customizable printing page similar to King Arthur's implementation

See here (click print):

@hay-kot hay-kot added task General Task that needs to be completed v1 Version 1 Issue/PR good first issue Good for newcomers labels Mar 21, 2022
@tbleiker
Copy link

When I chose print, I get:

  • Comments at the top (I would put this rather at the end - if at all...)
  • Left third of the page is blank (if side menu is not closed)
  • Empty ingredient list (except for the notes)
  • No section in the ingredient list (just all the ingredients after one another without the section title)

I tested with Firefox and Chrome on Linux. Server: Docker on Linux, most current frontend-nigthly (da57184c5690) and api-nightly (4ed3545a8de7) with sqlite.

@stale stale bot added the stale label May 26, 2022
@hay-kot hay-kot removed the stale label May 28, 2022
@hay-kot hay-kot self-assigned this May 28, 2022
@mealie-recipes mealie-recipes deleted a comment from stale bot May 28, 2022
@hay-kot hay-kot removed their assignment May 31, 2022
@hay-kot
Copy link
Collaborator Author

hay-kot commented May 31, 2022

When I chose print, I get:

  • Comments at the top (I would put this rather at the end - if at all...)
  • Left third of the page is blank (if side menu is not closed)
  • Empty ingredient list (except for the notes)
  • No section in the ingredient list (just all the ingredients after one another without the section title)

I tested with Firefox and Chrome on Linux. Server: Docker on Linux, most current frontend-nigthly (da57184c5690) and api-nightly (4ed3545a8de7) with sqlite.

I think all of these things are more or less addressed in the most recent nightly version

@hay-kot hay-kot added this to the v1.0.0beta-4 milestone May 31, 2022
@tbleiker
Copy link

tbleiker commented Jun 1, 2022

Looks a lot better now!

Last point is still a problem

  • No section in the ingredient list (just all the ingredients after one another without the section title)

@michael-genson
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers task General Task that needs to be completed v1 Version 1 Issue/PR
Projects
None yet
3 participants