Fix: increased float rounding precision for CRF parser #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
hay-kot
approved these changes
Jun 11, 2022
There was a problem hiding this comment.
LGTM. I added two test cases and fixed the failing tests since I have CRF++ installed on my computer.
Could you just double check the validator I added on the Pydantic model and make sure I'm not missing anything obvious? If I didn't do anything stupid, I'll go ahead and merge after that.
Comment on lines
+29
to
+34
| TestIngredient("⅔ cup unsweetened flaked coconut", 0.667, "cup", "coconut", "unsweetened flaked"), | ||
| TestIngredient("⅓ cup panko bread crumbs", 0.333, "cup", "panko bread crumbs", ""), | ||
| # Small Fraction Tests - PR #1369 | ||
| # Reported error is was for 1/8 - new lowest expected threshold is 1/32 | ||
| TestIngredient("1/8 cup all-purpose flour", 0.125, "cup", "all-purpose flour", ""), | ||
| TestIngredient("1/32 cup all-purpose flour", 0.03125, "cup", "all-purpose flour", ""), |
There was a problem hiding this comment.
I've added two test cases that pass on my machine and update the other two to work with the new significant digits we're using now.
There was a problem hiding this comment.
Yeah that looks good to me, and the tests make sense so if they're passing I don't see anything wrong with it!
|
Thanks for the sanity check! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue raised in #1358: the CRF parser rounds the float value to the nearest 1/10; this causes issues for smaller fractions. I increased the precision to 3, which is accurate down to increments of 1/32.
I also limited the denominator to a max of 32 to prevent float precision artifacts like 5980780305148019/72057594037927936 (which is really just 1/12).
Full disclosure: I'm having trouble getting the CRF parser running in dev, so I instead emulated the process locally. Since it's all built-in decimal handling it shouldn't matter, but it's worth checking a few test cases in dev before merging (such as the one mentioned in #1358).