Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode: Color issues #23

Closed
zackbcom opened this issue Jan 4, 2021 · 1 comment
Closed

Dark Mode: Color issues #23

zackbcom opened this issue Jan 4, 2021 · 1 comment

Comments

@zackbcom
Copy link
Contributor

zackbcom commented Jan 4, 2021 •
edited

What a great app. Whole family loves it. Found one issue with the dark mode.
I saw that the colors are randomized. Maybe it would be good to set a default set of colors that are accessible, following the WCAG 2.1 Guidelines.

I'm currently working on updating our application at work, I might have some free time to work on some enhancements.

Saw some issues with the generated colors and the text.
image
@hay-kot
Copy link
Collaborator

hay-kot commented Jan 6, 2021

I've changed the default info color to #4990BA. I've also removed the random color generation and replaced it with the default theme colors when creating a new theme. I'll keep this in mind for future enhancements. Thanks!

@hay-kot hay-kot closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zackbcom @hay-kot