Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.0.0b] - Recipe timeline events are not automatically created if Meal Plan is scheduled from the recipe page #2344

Closed
5 tasks done
shiruken opened this issue Apr 8, 2023 · 3 comments

Comments

@shiruken
Copy link

shiruken commented Apr 8, 2023

First Check

  • This is not a feature request
  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.

What is the issue you are experiencing?

Meal Plan entries automatically add a recipe timeline event on the scheduled date (#2050). However, this appears to only work when scheduled from the Meal Planner page. Recipe timeline events are not being created if added to the Meal Plan via the recipe page.

Deployment

Docker (Linux)

Deployment Details

Version: omni-nightly
Build: 03b7d9e

@shiruken shiruken changed the title [v1.0.0b] - Recipe timeline events are not created if scheduled from the recipe page [v1.0.0b] - Recipe timeline events are not automatically created if scheduled from the recipe page Apr 8, 2023
@shiruken shiruken changed the title [v1.0.0b] - Recipe timeline events are not automatically created if scheduled from the recipe page [v1.0.0b] - Recipe timeline events are not automatically created if Meal Plan is scheduled from the recipe page Apr 8, 2023
@michael-genson
Copy link
Collaborator

Do you happen to have any server logs handy on the date of the scheduled mealplan? (e.g. if your meal was scheduled for April 9th, your logs for April 9th).

The event doesn't get posted to the timeline until the day of the mealplan, so if there's an error, that's where the logs would be

@Grygon
Copy link
Contributor

Grygon commented May 20, 2023

I'm unable to reproduce the issue

  • Added recipe for today from Meal Plan page
  • Added recipe for today to Meal Plan from the Recipe
  • Added recipe for today to Meal Plan from the recipe overview

Then triggered the create_mealplan_timeline_events task manually, and all 3 had entries created for today.
Reading through the code, the only things I could see us not completing this on would be is if there's some missing attribution for group/recipe/user on what's in the meal plan, but I don't see how that could be possible...

@shiruken are you still able to recreate this in nightly? If so, more info on reproducing the issue might be helpful, since I've been unable to.

@shiruken
Copy link
Author

I haven't encountered this issue recently. I wonder if it was a byproduct of Meal Plan events that were scheduled prior to transitioning to the nightly build.

I will close issue for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants