Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Default group is missing after upgrade from 1.2.0 to 1.3.0 #3260

Closed
5 of 6 tasks
ghuser238490 opened this issue Mar 6, 2024 · 5 comments · Fixed by #3264
Closed
5 of 6 tasks

[BUG] - Default group is missing after upgrade from 1.2.0 to 1.3.0 #3260

ghuser238490 opened this issue Mar 6, 2024 · 5 comments · Fixed by #3264
Labels
bug: confirmed bug Something isn't working

Comments

@ghuser238490
Copy link

ghuser238490 commented Mar 6, 2024

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

After upgrading from 1.2.0 to 1.3.0 the default group seems to be missing:
The page https://my.server/admin/manage/groups shows no group entry and
the pages https://my.server/g/home/recipes/timeline
and https://my.server/group are blank.

After reverting to 1.2.0 the default group shows up again and the timeline page is ok.

Steps to Reproduce

Upgrade from 1.2.0 to 1.3.0
Access timeline on https://my.server/g/home/recipes/timeline
Look up default group on https://my.server/admin/manage/groups

Please provide relevant logs

INFO:     xxx.xxx.xxx.xxx:0 - "GET /api/groups/self HTTP/1.1" 500 Internal Server Error
ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/uvicorn/protocols/http/httptools_impl.py", line 419, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__
    return await self.app(scope, receive, send)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/fastapi/applications.py", line 1054, in __call__
    await super().__call__(scope, receive, send)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/applications.py", line 123, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/middleware/errors.py", line 186, in __call__
    raise exc
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/middleware/errors.py", line 164, in __call__
    await self.app(scope, receive, _send)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/middleware/gzip.py", line 24, in __call__
    await responder(scope, receive, send)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/middleware/gzip.py", line 44, in __call__
    await self.app(scope, receive, self.send_with_gzip)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 62, in __call__
    await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
    raise exc
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
    await app(scope, receive, sender)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/routing.py", line 758, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/routing.py", line 778, in app
    await route.handle(scope, receive, send)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/routing.py", line 299, in handle
    await self.app(scope, receive, send)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/routing.py", line 79, in app
    await wrap_app_handling_exceptions(app, request)(scope, receive, send)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
    raise exc
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
    await app(scope, receive, sender)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/routing.py", line 74, in app
    response = await func(request)
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/fastapi/routing.py", line 296, in app
    content = await serialize_response(
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/fastapi/routing.py", line 160, in serialize_response
    return field.serialize(
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/fastapi/_compat.py", line 147, in serialize
    return self._type_adapter.dump_python(
  File "/opt/pysetup/.venv/lib/python3.10/site-packages/pydantic/type_adapter.py", line 331, in dump_python
    return self.serializer.to_python(
pydantic_core._pydantic_core.PydanticSerializationError: Unable to serialize unknown type: <class 'mealie.db.models.group.webhooks.GroupWebhooksModel'>

Mealie Version

Version
v1.3.0
Build
e84e5e2910d128911c0c2050a60dfdc205fe277a

Deployment

Docker (Linux)

Additional Deployment Details

No response

@ghuser238490 ghuser238490 added bug Something isn't working triage labels Mar 6, 2024
@boc-the-git
Copy link
Collaborator

boc-the-git commented Mar 7, 2024

I'm unable to replicate this.

The error log you've attached, is that when running v1.3.0? Attempting to load what page exactly?

I note it references webhooks.. in your v1.2.0 instance can you please go to /admin/manage/groups/ and take a screenshot for me?
I do not have webhooks enabled, and I'm wondering if maybe you do and that's a key difference..

Are you also able to provide a backup file generated from your v1.2.0 instance? From /admin/backups

@hay-kot
Copy link
Collaborator

hay-kot commented Mar 7, 2024

@boc-the-git, I replicated it on the demo site. If you create a webhook in a group it will cause https://demo.mealie.io/admin/manage/groups/ to fail.

@hay-kot
Copy link
Collaborator

hay-kot commented Mar 7, 2024

Looks like the issue is isolated only to that page. No data loss or anything like that, just a validation error.

@ghuser238490
Copy link
Author

Hi @boc-the-git and @hay-kot , thanks for looking into this.
I deleted the webhook and everything's working fine again under v1.3.0.

@boc-the-git
Copy link
Collaborator

Glad that we have a temporary workaround at least.
I expect we'll publish v1.3.1 once we have a solution for this, though exact ETA on that is unknown.

Thanks for getting the demo instance updated @hay-kot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants