Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile exposes port 80, but runs on port 9000 #55

Closed
kentora opened this issue Jan 9, 2021 · 0 comments · Fixed by #57
Closed

Dockerfile exposes port 80, but runs on port 9000 #55

kentora opened this issue Jan 9, 2021 · 0 comments · Fixed by #57

Comments

@kentora
Copy link
Contributor

kentora commented Jan 9, 2021

The Dockerfile exposes port 80 (Inherited from tiangolo/uvicorn-gunicorn-fastapi which in turn inherits it from tiangolo/uvicorn-gunicorn), but the cmd in the dockerfile runs uvicorn on port 9000. I don't think there's any problem in running on port 80 in docker, since nothing else will run on the containers port 80 - and users can map the port however they like (The docker-compose.yml already maps to a different port than 9000).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants