Skip to content
This repository has been archived by the owner on May 26, 2018. It is now read-only.

Hide the window shadow while dragging on Mac #137

Closed
jaredhirsch opened this issue Aug 18, 2016 · 4 comments
Closed

Hide the window shadow while dragging on Mac #137

jaredhirsch opened this issue Aug 18, 2016 · 4 comments

Comments

@jaredhirsch
Copy link
Collaborator

On MacOS, there's a box shadow chasing the player as it's dragged around.

The fix is to set -moz-window-shadow: none on the panel while dragging.

I wasn't able to test this in the debugger, some debugger bug, I think. But it should work, it's used a lot in dxr.

@jaredhirsch jaredhirsch modified the milestone: MVP Aug 18, 2016
@meandavejustice
Copy link
Owner

How do you set css props on the actual panel? Do you have an example you can link to?

@jaredhirsch
Copy link
Collaborator Author

@meandavejustice You can get the panel like this: let el = getActiveView(panel). getActiveView comes from view/core.

To style it, you can just setAttribute('style', inlineStyles) to set inlineStyles. This is done in a couple places in dxr: https://dxr.mozilla.org/mozilla-central/search?q=panel.setAttribute+style&redirect=false

@jaredhirsch
Copy link
Collaborator Author

Hmm, I think you might have to set the styles in the older style: panelElement.style.property = value. I can take this bug.

@jaredhirsch jaredhirsch changed the title Hide the window shadow while dragging Hide the window shadow while dragging on Mac Aug 22, 2016
@jaredhirsch
Copy link
Collaborator Author

This was fixed by #179. Closing 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants