Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use 100% width for Puck frame when iframe disabled #414

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

chrisvxd
Copy link
Member

@chrisvxd chrisvxd commented Apr 3, 2024

#412 identified an issue that resulted in the preview width collapsing down to the width of the contents when iframes are disabled. If there is no contents, the preview would not be visible.

This fixes it by setting the width to 100%, as expected.

Closes #412

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 0:33am
puck-docs ✅ Ready (Inspect) Visit Preview Apr 3, 2024 0:33am

@chrisvxd chrisvxd merged commit 64303c8 into main Apr 3, 2024
4 checks passed
@chrisvxd chrisvxd deleted the fix-iframe-disabled-width branch April 3, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iframe enabled false has a UI issue
1 participant