New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parentObject from proto file #158

Open

Shahar-Y opened this issue Sep 3, 2019 · 2 comments

Assignees

Labels

good first issue refactor

Projects

Contributor

Shahar-Y commented Sep 3, 2019

it's deprecated

Shahar-Y added the refactor label

Shahar-Y added this to To do in file-service via automation

Contributor

yonatandt commented Sep 4, 2019

Do it in the next pull request that will change the file-service proto file.

Shahar-Y added the good first issue label

yoavrozner assigned menachem554

yoavrozner commented Jan 12, 2022 •

edited by menachem554

Loading

Create a new branch from develop.
Make sure that the parentObject is not in use in the code.
Remove it from the proto file.
Regenerate the new proto.
Run the tests.
Use bloom rpc to check manually the functionality.
Update the changelog.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment