Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback homework week 2 #1

Open
remarcmij opened this issue May 3, 2018 · 1 comment
Open

Feedback homework week 2 #1

remarcmij opened this issue May 3, 2018 · 1 comment

Comments

@remarcmij
Copy link

Hi Meazer, here is my feedback on your homework for week 2.

You've done a great job here. Your code works correctly, is nicely formatted and your choice of variable names is excellent.

A couple of minor points.

1-stings.js

1. This file should actually be named strings.js.

2. Be consistent in your use of quotes as string delimiter. Either choose single quotes or double quotes and then stick to that for all of your code (I prefer single quotes myself).

2-arrays.js

3. This file is missing a 'use strict' line.

3-months.js

4. It is best to always use strict equality: use === instead of ==.

4-maartje.js

5. This file is missing a 'use strict' line.

@Meazer
Copy link
Owner

Meazer commented May 7, 2018

Hi Jim,

Thank you for your feedback, I have implemented it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants