-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playwright-assets should be extracted and referenced as a dependency for dev/test #10
Comments
maybe we could pattern things after how esbuild is installed in a new Elixir/Phoenix app? |
I'm not sure the value in extracting the documents - it will make testing and adding features and pull requests a LOT harder since now two different repos will needs modification in tandem. The main issue I see is your third point around language statistics. Can you just use something like this instead: Make it independent just for in case of future use to me seems not worth it for the complexity it may add. Just my $0.02. |
Thanks for the solution for the language statistics! I had no idea about that, but love the result. I did decide to go ahead and extract the assets to playwright-assets. Though you've already provided an exception, @dbrody (with the cookies tests), I believe it will seldom be the case that developers working on playwright-elixir will need to do much with the assets. The hope/intention is that we'll almost always be able to use the assets from the official Node.js Playwright, and bump those to match versioned releases. Additionally, being able to run the assets server standalone will make it easier to restore WebSocket transport testing our CI pipeline(s). |
Closing for now... happy to discuss further. |
Some work has already been done to extract the test assets to playwright-assets. It would be nice to have that be capable of loading and running as a dependency for this project so that:
The text was updated successfully, but these errors were encountered: