Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The train/val split in domainnet #6

Open
FrankZhangRp opened this issue Oct 8, 2022 · 1 comment
Open

The train/val split in domainnet #6

FrankZhangRp opened this issue Oct 8, 2022 · 1 comment

Comments

@FrankZhangRp
Copy link

we find that the train sets are kept the same size on all domains as the 'min_data_len' and we think there is a mistake:

min_data_len = int(min_data_len * 0.05)

@FrankZhangRp
Copy link
Author

if the 'trainset' is only 5% of the total dataset, the training process is too toy and unstable with about 100+ samples per client without pretrained weights. We think the train/val split may be 95% / 5%, but in this code is 5% / 5%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant