Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos not adding to playlist as expected | Windows 11 #708

Closed
isaacy13 opened this issue Feb 18, 2024 · 5 comments
Closed

Videos not adding to playlist as expected | Windows 11 #708

isaacy13 opened this issue Feb 18, 2024 · 5 comments

Comments

@isaacy13
Copy link

isaacy13 commented Feb 18, 2024

Howdy all,

I'm running into an issue where calling player.add(Media(...)) isn't adding the media to the playlist, despite no error being thrown in .onError

  • media_kit 1.1.10
  • media_kit_video 1.2.4
  • media_kit_libs_video 1.0.4

** was previously using older versions of library & running into same issue, updating to latest did not resolve behavior

Repo steps:

  • await player.open(Playlist([Media(...)]), play: true)
  • await player.add(Media(...))
  • await player.add(Media(...))
  • await player.add(Media(...))
  • Even though .onError will not be called & .then will execute, the playlist will only have 3 items

Notes:

  • in my actual code, I'm limited to two items -- so # of videos don't seem to be issue
  • if you change order you open videos (e.g.: D, C, B, A instead of A, B, C, D) this behavior still occurs -- so issues don't seem to be with video files
@isaacy13
Copy link
Author

isaacy13 commented Feb 18, 2024

Repro code

  • in this example, video C is omitted from playlist
  • playlist contents are [A, B, D]

--- main.dart

void main(List<String> args) {
   MediaKit.ensureInitialized();
   runApp(ReproApp);
}

--- repro_app.dart
example.txt

@abdelaziz-mahdy
Copy link
Member

abdelaziz-mahdy commented Feb 18, 2024

can you provide logs?

 player =
        Player(configuration: PlayerConfiguration(logLevel: MPVLogLevel.debug));
    player.stream.log.listen((event) {
      print("log $event");
    });

just incase its a problem with mpv

@isaacy13
Copy link
Author

Ah yeah, looks like path character issue (emojis and/or apostrophes)

  • first video with apostrophe worked, but second video with apostrophes in path had fatal error
  • confirmed removing special characters fixed issue
image

media_kit_video_logs.txt

@abdelaziz-mahdy
Copy link
Member

nice, glad it got fixed

@isaacy13
Copy link
Author

isaacy13 commented Mar 2, 2024

Any chance there'd be plans to support files with special characters in them? (e.g.: apostrophes, emojis, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants