Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable --vo=gpu-next Support on Darwin to Reshape Dolby Vision Content #777

Closed
shivabohemian opened this issue Apr 19, 2024 · 2 comments
Closed

Comments

@shivabohemian
Copy link

In the latest version of mpv 0.38, the issue with Vulkan instance creation on macOS has been fixed (the pr). Here, we can use --vo=gpu-next to support content reshaping for Dolby Vision (you can use test videos here). I noticed that the darwin builds of the media-kit package are using an older version of mpv and Vulkan is not enabled. So, do we need to update libmpv-darwin-build?

@birros
Copy link
Member

birros commented Apr 19, 2024

See media-kit/libmpv-darwin-build#28.

Unfortunately, I don't think libmpv uses Vulkan, but only OpenGL like previous versions. It seems to me that Vulkan is only for direct rendering in a native view.

To use Vulkan in media-kit, we need to :

  • Wait for libmpv to replace OpenGL with Vulkan
  • Or use a Platform View from Flutter, but I don't think this API is yet stable for macOS, and that it would be as efficient

@shivabohemian
Copy link
Author

All right. It looks like gpu-next is still not supported in the rendering API (mpv-player/mpv#10810). So, as it stands, it appears that Dolby Vision tone mapping is also not properly supported on the medit-kit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants