New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chromecast] seems to registerElement multiple times #56
Comments
Can you send me a URL to check this please? |
It can only be one sender per page; I implemented something that might help you: Let me know your thoughts; otherwise, you might need to reach Chromecast directly, since I couldn't find any documentation about this, other than the fact there should be only one instance of the player per page |
Can use that But I Think this will be a recurring issue among others so I think it would be best if built in to the plugin |
Please download the master branch; I was able to put a restriction so only one sender per page is now allow and you can use https://jsfiddle.net/Luuwnjfm/1/ without any hacks. Let me know |
Works |
I'm glad it worked for you |
Hmm, didn't work where we'll The Chromecast don't appear after I set a video source. And the check for the button makes it never appear cuz it's always true? |
I'll check this on your scenario; do you have a fiddle that I can use for testing scenario? |
If you get this fiddle to work without modification then i think you have solved both my Chromecast bugs
(as you can see |
@jimmywarting Can you try this Fiddle and check if that solves your issues? https://jsfiddle.net/Luuwnjfm/8/ |
Any updates on this? |
The chromecast isn't available after I set a source |
Hmmm I'll take a look at this again. It was working for me before |
maybe that isn't the problem.
which makes this code return early without building the cast button |
Hmmmm yeah I need to research how to check if the button has been truly registered, because I thought that would be enough. I'll keep you posted |
@jimmywarting OK I think I finally got it; I added a new Fiddle so you can see the end result. Dealing with Chromecast is a little complicated so I'll be thinking in a better way to do this but for now you should get everything fine: https://jsfiddle.net/Luuwnjfm/13/. Let me know |
@jimmywarting I have refactor MediaElement to integrate Chromecast inside the player and not as a plugin. If you can help me testing this, please test this Fiddle so it can be part of the next release: https://jsfiddle.net/Luuwnjfm/18/ |
FYI i have completed more work to enable errors properly on the player UI but that should affect your testing. Keep me posted since I'm planning to release this week |
@jimmywarting I have 2 new branches (one for the player and one for the plugins) named the same: features: ['playpause', 'current', 'progress', 'duration', 'speed', 'volume', 'chromecast'] **You will need to include chromecast.min.js ** after the |
@rafa8626 Thanks for your work. Testing your new code. I'm getting following tag for chromecast button |
The |
Closing this issue since all issues related to Chromecast have been discussed and addressed on mediaelement/mediaelement#2273 |
I got a single page website, so when I create a new player i get this error:
The text was updated successfully, but these errors were encountered: