Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silverlight player: volumechange event before the new value is set #36

Closed
sompylasar opened this issue Dec 3, 2010 · 2 comments
Closed

Comments

@sompylasar
Copy link

The w3c spec says:

volumechangeEventEither the volume attribute or the muted attribute has changed. Fired **after** the relevant attribute's setter has returned.

but the Silverlight version of the player seems to send volumechange event before the new value is actually set:
// src/silverlight/MainPage.xaml.cs:318
public void setVolume(Double volume) {
...
SendEvent("volumechange");
media.Volume = volume;
and
// src/silverlight/MainPage.xaml.cs:327
public void setMuted(bool isMuted) {
...
SendEvent("volumechange");
media.IsMuted = isMuted;

@johndyer
Copy link
Collaborator

johndyer commented Dec 3, 2010

Good find! I'll check it out.

@johndyer
Copy link
Collaborator

johndyer commented Dec 6, 2010

Fixed.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants