-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chroma.js #16
Comments
Yes that will fix a number of current issues! I'm in the process of updating the tool, but the change is bigger than I expected and impacts many aspects. The biggest issue is that previous Chroma returned |
For color validation I recommend using D3 v4 module called d3-color. Mike Bostock created
|
Thanks for this advice :) ! |
I updated Chroma. I did not implement your suggestion and sticked to a tweak copied from Chroma source code. I think the next step would be to package the library into a d3 compatible module not requiring Chroma, but that's for another time! Thanks for your suggestions anyway. |
You're welcome! BTW looks like colors at http://tools.medialab.sciences-po.fr/iwanthue/ are still yellowish with C=0. |
The repo is up to date but not yet the online website. In a few days. |
Newer versions of chroma.js changes HCL representation (called LCH somewhy), same as in D3.js.
Updating the library will make colors with C=0 true grayscale instead of yellowish.
Any version of chroma.js >=0.4.8 will do.
Check the commit with mentioned changes at chroma.js repo: gka/chroma.js@42dd32a
The text was updated successfully, but these errors were encountered: