-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve browser focusable tests #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyrehm
force-pushed
the
improve-browser-focusable-tests
branch
4 times, most recently
from
December 29, 2015 12:30
a855c19
to
fe62e2e
Compare
Braindump: I'm wondering if the following utilities should rather be exposed in the
I'm not sure about the document/window helpers, they might as well go into the
|
rodneyrehm
force-pushed
the
improve-browser-focusable-tests
branch
5 times, most recently
from
December 30, 2015 20:30
2cc5c6b
to
5530ff7
Compare
…of redirected focus
The manual browser focus compatibility test has been rewritten from scratch. The following items are left open: Test anomalies
False results of previous test infrastructure
Data Tables
|
rodneyrehm
force-pushed
the
improve-browser-focusable-tests
branch
2 times, most recently
from
January 10, 2016 11:14
bac1c35
to
d457e66
Compare
this is a complete rewrite of the test infrastructure to allow * running individual element tests asynchronously (fixing issue with Image Maps in Firefox) * running individual element tests atomically * collecting document and ShadowHost per element * collecting tabsequence real focus target (without ancestry) * collecting the focus ancestry (ShadowDOM, iframe, …) for select elements * collecting :focus css pseudo class state * producing an output format that is immediately usable
rodneyrehm
force-pushed
the
improve-browser-focusable-tests
branch
from
January 11, 2016 20:59
d457e66
to
0654e7b
Compare
…liably detectable)
rodneyrehm
force-pushed
the
improve-browser-focusable-tests
branch
from
January 12, 2016 10:24
0654e7b
to
0f82d47
Compare
rodneyrehm
force-pushed
the
improve-browser-focusable-tests
branch
2 times, most recently
from
January 12, 2016 14:36
9e13250
to
e730e76
Compare
…ant, but only the valid ones focusable
rodneyrehm
force-pushed
the
improve-browser-focusable-tests
branch
from
January 12, 2016 14:48
e730e76
to
5efe1d3
Compare
rodneyrehm
force-pushed
the
improve-browser-focusable-tests
branch
from
January 12, 2016 19:01
5efe1d3
to
ccce088
Compare
rodneyrehm
added a commit
that referenced
this pull request
Jan 12, 2016
Improve browser focusable tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted anything concerning
tests/focusable/*
from #80.Changes to the focusable test
<input type="reset">
test<iframe>
,<object>
and<embed>
<form>
and<form disabled>
(issue in IE)Changes to data tables structure
data-tables/focusable.redirect.html
intodata-tables/focusable.html
, thereby adding theT
note to explain "focus target forwarding" and "focus encapsulation".Issues with data tables
meta.expected.json
should know the expected redirection target (e.g. for "fieldset legend")meta.expected.json
needs adjustment for* within <embed tabindex="-1">
and* within <object tabindex="-1">
focusable.strict.html
needs styling for "redirecting" (color, attribute, notes)focusable.strict.html
needs improved visualization of the categorical inert in for "SVG document in" [<iframe>
,<embed>
,<object>
] and<iframe>
content. (current state is unnecessarily detailed)focusable.strict.html
needs to checkally.get.focusTarget
for inert elements to match the redirecting state (but ignore "parental redirection")Shadow DOM host elements are identifiedIgnoring this until Tabindex Focus Navigation Explainer led somewheretabbable
oronly-tabbable
in Chrome and Firefox, but should probably be a new state along the lines ofcontained
Issues with results
<input> within <form disabled>
is inert in IE9-11<div style="display: flex">
is focusable in IE10, IE11<div id="shadow-host-1">
is identified focusable in IE9-11, but it is not<div id="shadow-host-3" tabindex="0">
is identified focusable in IE9-12, but it is tabbable<legend>
redirects focus differently in Chrome (first focusable in<fieldset>
) and Firefox (next item in document's tab-sequence after<legend>
)<object type="image/svg+xml" data="…" height="0">
is identified as focusable in Safari 9 and iOS 9, but is tabbable?! - fishyinert
oronly-tabbable
in Firefox - fishy There's definitely something buggy in FirefoxIssues with ally.js functionality
platform.name
checks should be replaced byplatform.layout
to increase "derivative browser" compatibility (such as Opera 34, which uses Blink)ally.get.focusRedirectTarget
should identify focus redirections (not encapsulations)ally.get.focusTarget
should useally.get.focusRedirectTarget
ally.is.focusRelevant
should identify elements withShadowRoot
because they might receive focus andally.is.focusable
should revert thatThis PR is concerned with improving the focus test coverage and immediate issues with inert/focusable/tabbable/redirecting stateally.query.tabbable
andally.query.tabsequence
need to compensate swallowed elements (Gecko 1116126)While focusing the child of a flexbox-layouted link is a problem, clicking on a div that gets focus is the same as clicking on a scrollable element.ally.fix.pointerFocusChildren
should also cover<div style="display: flex">
being considered focusable bei IE10 and IE11an attempt at this is started in the branch feature/content-documentally.query.*
should accept<object>
and<iframe>
context and dive into their contentWindows