Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Sequence Streaming: Request to Contribute to Fast Image Sequence Renderer #38

Open
kimhongyeon opened this issue Jul 6, 2024 · 2 comments

Comments

@kimhongyeon
Copy link

kimhongyeon commented Jul 6, 2024

Hello,

I am a web frontend developer from Korea and I have been using the Fast Image Sequence Renderer extensively.

Recently, my company requested that I play thousands, even tens of thousands of captured images in a sequence like a video. Although I could convert them into a video format and use the video tag, due to internal constraints, I had to develop a solution by stitching the images together.

That’s when I found the Fast Image Sequence Renderer, and it has been incredibly useful. It’s really fast, has no dependencies, and is very performance-efficient. I am truly grateful for this tool.

However, I recently received a new requirement for streaming.

Fast Image Sequence Renderer, as it stands, is difficult to add frames to once initialized. It requires reinitialization to add more frames, which is inefficient and complicates the code since new images keep coming in over a short period, characteristic of streaming.

So, I forked the project and created a new public method called addMoreFrames. It works really well.

I would like to contribute this addMoreFrames feature to the Fast Image Sequence Renderer project by submitting a PR.

Thank you.

@reindernijhoff
Copy link
Member

Thanks for your post and the PR! I'm glad you like the fast-image sequence; that's nice to hear.

  • If you encounter any errors or have suggestions for improving or clarifying the code and/or documentation, I'd love to hear about them.

  • The source code is available under the MIT license. As far as I understand, this means you can do what you want. So feel free to fork this project and adapt it to your needs.

  • Finally, about the pull request. Why do you need an addMoreFrames function? Is this because you don't know exactly how many frames the sequence will have in advance? Or is this because you want to preload additional frames later? Or is there any other reason?
    In your current pull request, you recreate all frames and input sources without destructing the old ones. This could cause memory leaks but is also, as far as I can estimate, no faster than an entire destruct/re-init of the sequence renderer.

@kimhongyeon
Copy link
Author

Thank you for appreciating my PR.

The answers to your questions are included in the PR Reply, so you can refer to them there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants