Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linting] add lint-scripts #44

Open
Tracked by #39
psimk opened this issue Apr 19, 2022 · 0 comments
Open
Tracked by #39

[Linting] add lint-scripts #44

psimk opened this issue Apr 19, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@psimk
Copy link

psimk commented Apr 19, 2022

@pota/lint-scripts

Commands

  • fix - runs all fix commands synchronously or in parallel
  • fix:scripts - runs a JavaScript/TypeScript code linter, with auto-fixing
  • fix:style - runs a CSS/SASS/Styled Components code linter, with auto-fixing
  • lint - runs all lint commands synchronously or in parallel
  • lint:scripts - runs a JavaScript/TypeScript code linter
  • lint:style - runs a CSS/SASS/Styled Components code linter

Description

We have already been using a setup similar to this in most of our templates, for example the @pota/muban-template:

package.json

"scripts": {
  "fix": "run-s fix:* && npm run format",
  "fix:eslint": "npm run lint:eslint -- --fix",
  "lint": "run-s lint:*",
  "lint:eslint": "eslint . --ext .ts,.tsx --cache --cache-location node_modules/.cache/.eslintcache"
},

The fix and lint commands are implemented using npm-run-all, and fix:eslint is just running lint with an additional --fix argument for eslint.

scripts linting can be implemented using eslint and style linting can be implemented using stylelint.


See #39 for context

@psimk psimk mentioned this issue Apr 19, 2022
7 tasks
@psimk psimk self-assigned this Apr 19, 2022
@psimk psimk added new-feature help wanted Extra attention is needed enhancement New feature or request and removed new-feature labels Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant