Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reply in transition #150

Merged
merged 8 commits into from Sep 5, 2018
Merged

reply in transition #150

merged 8 commits into from Sep 5, 2018

Conversation

armonge
Copy link
Contributor

@armonge armonge commented Sep 4, 2018

  • Now users can use voxa2 style transitions with reply

Also:

  • removed unused ask-sdk and ask-sdk-core dependencies, we only need
    ask-sdk-model
  • started using prettier
  • removed the Rendering system support for random, this is now handled
    in the directives

- Now users can use voxa2 style transitions with `reply`

Also:
- removed unused `ask-sdk` and `ask-sdk-core` dependencies, we only need
`ask-sdk-model`
- started using prettier
- removed the Rendering system support for random, this is now handled
in the directives
@coveralls
Copy link

coveralls commented Sep 4, 2018

Coverage Status

Coverage increased (+0.7%) to 88.705% when pulling 2b5bc4e on armonge:task/reply-directive into 9db4d69 on mediarain:v3.


.. js:attribute:: AlexaEvent.requestToIntent
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i removed this cause it's a method meant to be used internally by the framework. I also updated the code to have this as a protected method


.. js:attribute:: AlexaEvent.alexa.deviceAddress

When a customer enables your Alexa skill, your skill can obtain the customer's permission to use address data associated with the customer's Alexa device., see :ref:`alexa-device-address`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

., period or comma, use one or the other


:returns Array: A string array of the platform's supported interfaces
Alexa customers have access to two default lists: Alexa to-do and Alexa shopping, see :ref:`alexa-lists`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not only for those lists, they can access any list created by themselves or any other Alexa skill, let's reword this

{ Dish: 'Fried Chicken' }
..

in other platforms it does it best to make the intent params for each platform also available on ``intent.params``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • it does its...

@armonge armonge merged commit 8ef4fc9 into VoxaAI:v3 Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants