Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain to prefix leaves _w or _wiki in filenames. #215

Open
robkam opened this issue Nov 5, 2023 · 2 comments · May be fixed by #216
Open

Domain to prefix leaves _w or _wiki in filenames. #215

robkam opened this issue Nov 5, 2023 · 2 comments · May be fixed by #216

Comments

@robkam
Copy link
Member

robkam commented Nov 5, 2023

On Windows, (Git Bash and WSL). Converting domains to prefix leaves trailing _w

e.g. for https://desencyclopedie.org the archive at https://archive.org/details/wiki-desencyclopedie.org_w-20231104 the filename prefix should be desencyclopedieorg but has a trailing _w
robkam added a commit that referenced this issue Nov 5, 2023
@robkam
fix trailing _w
ac6dd05 
fix #215 
strip third / to eol
+ remove redundant / to _
@robkam robkam linked a pull request Nov 5, 2023 that will close this issue
Open
@yzqzss
Copy link

yzqzss commented Nov 5, 2023

not a bug, it is what it is.

@robkam
Copy link
Member Author

robkam commented Nov 5, 2023

there is no label for cruft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix trailing _w mediawiki-client-tools/mediawiki-dump-generator
2 participants
@robkam @yzqzss