Add CONTRIBUTING Guide #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elsie Hupp <github@elsiehupp.com>
elsiehupp
requested review from
cooperdk,
randomnetcat,
robkam,
NyaMisty,
t-karcher and
vgambier
|
I'm not sure what's meant on line 55 by "You don't have to do so up front, but we ask that you do so when you...". Otherwise it looks fine. |
It means "You don't have to do so up front, but we ask that you [follow these best practices for writing a commit message] when you [open a pull request]," but, yeah, the wording is a bit awkward... (By the way, you should be able to make commits on this Pull Request yourself, if you'd like to tweak the wording. I did this myself on one of your recent Pull Requests.) |
clarifying the wording about commits
|
The main substance lgtm. Haven't carefully examined the wording but can do so later. |
elsiehupp
commented
Aug 28, 2023
Merged
robkam
approved these changes
Aug 28, 2023
elsiehupp
added a commit
that referenced
this pull request
Aug 29, 2023
Fixes #82. This branch is based on #177, so it cannot be merged before the CONTRIBUTING branch is merged. Note that I believe it is less than ideal for me, Elsie Hupp, to have sole responsibility for CoC reports, but I also think it's better to have an initial framework in place rather than none at all. --------- Signed-off-by: Elsie Hupp <github@elsiehupp.com> Co-authored-by: Rob Kam <robkam@gmx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering the frustrations with our development process, I figured it was well past time to put together a written set of best practices.
This Pull Request partially addresses @NyaMisty's Issue #82 (but not fully), so @mediawiki-client-tools @yzqzss everyone please do comment on this and make or suggest any changes.
(I am marking as a draft in order to give everyone time to respond before this gets merged.)
Note that as @robkam mentioned, the "Code of Conduct" is kind of a separate Issue from the "Contributing" guide; I can open a Pull Request for that next.