Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flag type #14

Open
Maxoos opened this issue Aug 26, 2013 · 1 comment
Open

flag type #14

Maxoos opened this issue Aug 26, 2013 · 1 comment

Comments

@Maxoos
Copy link

Maxoos commented Aug 26, 2013

Hi all,

Great work, thanks!

It would be nice to have flag types, like lets say "bookmark", "favourite", "keep" and then you might be able to do:

user.bookmark! and not User.flag!(bookmark)

Have you thought about this?

@mbajur
Copy link

mbajur commented Nov 3, 2013

+1
I don't actually get it. There is a type column in table and i can see that line in readme:

# Returns true if the flagger flagged the flaggable, false otherwise.
user.flagged?(article, :flag_name)

But it's not working and, as i can see in the code, is not implemented. Can anyone clear this out?


Edit: sorry, this column name is actualy flaggable_type and it's not what i thought. But, still, the mentioned line from readme is a bit unclear.

I think i should come up with PR for that this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants