fix(gate): resolution of rejected promise

In some cases failed promise was returned as successful
medikoo · May 25, 2017 · f6fe524 · f6fe524
1 parent 470a4db
commit f6fe524
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/ext/function/gate.js b/ext/function/gate.js
@@ -51,7 +51,7 @@ module.exports = function (cLimit, qLimit) {
 				if (def) def.resolve(r);
 				return r.finally(decrement);
 			}
-			r = r.value;
+			if (!r.failed) r = r.value;
 		}
 		if (!def) return resolve(r);
 		def.resolve(r);

diff --git a/test/ext/function/gate.js b/test/ext/function/gate.js
@@ -106,6 +106,13 @@ module.exports = function (t) {
 			dz.resolve(z);
 			dy.resolve(y);
 			dx.resolve(x);
+		},
+		"Resolution type": function (a) {
+			var error = new Error("Test");		
+			gfn = t.call(function () { return deferred.reject(error); }, 1, 0);
+			gfn().done(a.never, function (err) {
+				a(err, error);
+			});
 		}
 	};
 };