feat: if listed copy not only if own property

medikoo · May 17, 2017 · d7e7cef · d7e7cef
1 parent f1d1179
commit d7e7cef
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/object/copy.js b/object/copy.js
@@ -1,17 +1,16 @@
 'use strict';
 
-var aFrom                = require('../array/from')
-  , assign               = require('./assign')
-  , value                = require('./valid-value')
-  , propertyIsEnumerable = Object.prototype.propertyIsEnumerable;
+var aFrom  = require('../array/from')
+  , assign = require('./assign')
+  , value  = require('./valid-value');
 
 module.exports = function (obj/*, propertyNames*/) {
 	var copy = Object(value(obj)), propertyNames = arguments[1];
 	if (copy !== obj && !propertyNames) return copy;
 	var result = {};
 	if (propertyNames) {
 		aFrom(propertyNames, function (propertyName) {
-			if (propertyIsEnumerable.call(obj, propertyName)) result[propertyName] = obj[propertyName];
+			if (propertyName in obj) result[propertyName] = obj[propertyName];
 		});
 	} else {
 		assign(result, obj);

diff --git a/test/object/copy.js b/test/object/copy.js
@@ -24,4 +24,6 @@ module.exports = function (t, a) {
 	a(o.raz, no.raz, 'Shallow');
 
 	a.deep(t(o, ['foo']), { foo: 'bar' });
+	a.deep(t(Object.create(o), ['foo']), { foo: 'bar' });
+	a.deep(t(o, ['foo', 'habla']), { foo: 'bar' });
 };