Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround to postinstall to prevent npx error #110

Merged
merged 2 commits into from Mar 8, 2022

Conversation

martindrq
Copy link
Contributor

@martindrq martindrq commented Mar 8, 2022

This workaround try to fix this issue:

Fixes #109

And its based on the same problem in core-js lib:

zloirock/core-js#551

Copy link
Owner

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @martindrq ! It looks great, I have just one concern

_postinstall.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #110 (e3c6924) into main (33ace05) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files         425      425           
  Lines        2608     2608           
=======================================
  Hits         2396     2396           
  Misses        212      212           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ace05...e3c6924. Read the comment docs.

@medikoo medikoo merged commit e212d5a into medikoo:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.10.54 release breaks package installation
2 participants