fix: ensure to not force unhandled rejections

medikoo · Aug 13, 2018 · 9b416ea · 9b416ea
1 parent 855c460
commit 9b416ea
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/ext/promise.js b/ext/promise.js
@@ -66,7 +66,9 @@ require("../lib/registered-extensions").promise = function (mode, conf) {
 
 		if (resolvedMode === "then") {
 			var nextTickFailure = function () { nextTick(onFailure); };
-			promise.then(function (result) {
+			// Eventual finally needs to be attached to non rejected promise
+			// (so we not force propagation of unhandled rejection)
+			promise = promise.then(function (result) {
 				nextTick(onSuccess.bind(this, result));
 			}, nextTickFailure);
 			// If `finally` is a function we attach to it to remove cancelled promises.