Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use provider.request instead of custom ec2 instance #8

Merged
merged 3 commits into from Oct 21, 2021
Merged

fix: use provider.request instead of custom ec2 instance #8

merged 3 commits into from Oct 21, 2021

Conversation

onhate
Copy link
Contributor

@onhate onhate commented Oct 13, 2021

closes: #1
closes: #4

medikoo
medikoo requested changes Oct 14, 2021
View reviewed changes
Copy link
Owner

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @onhate! That's a great call. I've just proposed two style updates, and we should be good to go

index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@onhate
Copy link
Contributor Author

onhate commented Oct 14, 2021

@medikoo I'll fix the tests

@onhate onhate requested a review from medikoo October 20, 2021 12:27
medikoo
medikoo approved these changes Oct 21, 2021
View reviewed changes
Copy link
Owner

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @onhate ! That looks great

@medikoo medikoo merged commit eca8e57 into medikoo:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VPC ENI Cleanup: Error: Missing credentials in config bug: Uses default credentials instead of provider
2 participants
@onhate @medikoo