fix: ensure 'is' functions can't crash

medikoo · Apr 4, 2019 · 59ceb78 · 59ceb78
1 parent 45f1ddd
commit 59ceb78
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 14 deletions.
diff --git a/array/is.js b/array/is.js
@@ -15,9 +15,13 @@ module.exports = function (value) {
 
 	// Sanity check (reject objects which do not expose common Array interface)
 	if (!hasOwnProperty.call(value, "length")) return false;
-	if (typeof value.length !== "number") return false;
-	if (typeof value.push !== "function") return false;
-	if (typeof value.splice !== "function") return false;
+	try {
+		if (typeof value.length !== "number") return false;
+		if (typeof value.push !== "function") return false;
+		if (typeof value.splice !== "function") return false;
+	} catch (error) {
+		return false;
+	}
 
 	return !isPrototype(value);
 };
diff --git a/date/is.js b/date/is.js
@@ -7,14 +7,17 @@ var dateValueOf = Date.prototype.valueOf;
 module.exports = function (value) {
 	if (!value) return false;
 
-	// Sanity check (reject objects which do not expose common Date interface)
-	if (typeof value.getFullYear !== "function") return false;
-	if (typeof value.getTimezoneOffset !== "function") return false;
-	if (typeof value.setFullYear !== "function") return false;
+	try {
+		// Sanity check (reject objects which do not expose common Date interface)
+		if (typeof value.getFullYear !== "function") return false;
+		if (typeof value.getTimezoneOffset !== "function") return false;
+		if (typeof value.setFullYear !== "function") return false;
 
-	// Ensure its native Date object (has [[DateValue]] slot)
-	try { dateValueOf.call(value); }
-	catch (error) { return false; }
+		// Ensure its native Date object (has [[DateValue]] slot)
+		dateValueOf.call(value);
+	} catch (error) {
+		return false;
+	}
 
 	// Ensure it hosts valid date
 	if (isNaN(value)) return false;

diff --git a/error/is.js b/error/is.js
@@ -9,7 +9,11 @@ module.exports = function (value) {
 	if (!value) return false;
 
 	// Sanity check (reject objects which do not expose common Error interface)
-	if (typeof value.message !== "string") return false;
+	try {
+		if (typeof value.message !== "string") return false;
+	} catch (error) {
+		return false;
+	}
 
 	// Ensure its native Error object (has [[ErrorData]] slot)
 	// Note: it's not 100% precise as string tag may be overriden

diff --git a/reg-exp/is.js b/reg-exp/is.js
@@ -12,9 +12,13 @@ module.exports = function (value) {
 
 	// Sanity check (reject objects which do not expose common RegExp interface)
 	if (!hasOwnProperty.call(value, "lastIndex")) return false;
-	if (typeof value.lastIndex !== "number") return false;
-	if (typeof value.test !== "function") return false;
-	if (typeof value.exec !== "function") return false;
+	try {
+		if (typeof value.lastIndex !== "number") return false;
+		if (typeof value.test !== "function") return false;
+		if (typeof value.exec !== "function") return false;
+	} catch (error) {
+		return false;
+	}
 
 	// Ensure its native RegExp object (has [[RegExpMatcher]] slot)
 	if (isToStringTagSupported && typeof value[Symbol.toStringTag] === "string") {