Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Irish Surnames #8

Closed
jdrew1303 opened this issue Nov 10, 2016 · 2 comments
Closed

Handling Irish Surnames #8

jdrew1303 opened this issue Nov 10, 2016 · 2 comments

Comments

@jdrew1303
Copy link

First off this is a great little module 👍

There is a small issue with Irish family names. Some are perfectly fine:
image
image

But if you have a Ó as part of your family name it parses out as a middle name:
image

This will probably be a problem for countries that have a significant Irish lineage (UK, USA and Australia as well as Ireland 😁 )

@hugovk
Copy link

hugovk commented Feb 27, 2018

This might be related to the problem with Dutch names: #7.

@mattschuette
Copy link
Member

Version 1.2.0 now supports many surname prefixes, including Ó as mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants