Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediumroast_js: After company name is specified, for non-public companies, it shows up as Unknown #58

Closed
miha42-github opened this issue Jan 2, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@miha42-github
Copy link
Contributor

Introduction

When creating non-public companies the initial set of the name does not take and instead reverts to the default of Unknown. This results secondary impacts, notably the helper URLs for Google maps, Google patents and Google news are also set to Unknown.

@miha42-github
Copy link
Contributor Author

This appears to be the result of not having a complete object sent to the companyWizard module. An initial change has been made hopefully to remedy the behavior. If this fixes the problem then the associated issue should also be resolved.

Specifically, mrcli-setup set env.DEFAULT.company as the name and mrcli-company did not have this attribute in the env object as it was passed to the wizard module. We've overall changed the attribute to env.company and are ready to test the implementation. If this does not work deeper work is needed.

@miha42-github
Copy link
Contributor Author

miha42-github commented Jan 12, 2024

Some incremental feedback, on the initial take at a fix. It may not have stuck a more complete walkthrough likely needed. More information to come when additional companies are added after setup. The initial process in setup shows that when the company name is verified an updated name doesn't stick.

One part of the problem is that the default value was showing and not the set value. It could be fixed, but unsure just yet.

@miha42-github
Copy link
Contributor Author

This now appears to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants