Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disposition CSV-based packet definition code #40

Open
medley56 opened this issue Mar 28, 2024 · 0 comments
Open

Disposition CSV-based packet definition code #40

medley56 opened this issue Mar 28, 2024 · 0 comments
Labels
breaking This involves a breaking change enhancement New feature or request help wanted Extra attention is needed

Comments

@medley56
Copy link
Owner

There is some old CSV-based packet definition code that has not been worked on in a long time. This code works fundamentally differently from the XTCE code and the functionality is much more limited.

Specific issues that need attention:

  1. Documentation of CSV format supported by the CsvPacketDefinition class.
  2. Improved unit tests for CSV-based packet parsing.
  3. Separation of concerns between CSV-based parsing and XtcePacketDefinition. There are currently deprecated methods in XtcePacketDefinition that are only there in order to prevent breakage of the CSV-based parser.

We can either take the action to make these updates or we can just remove the CSV parsing from the package. I'd rather do the former because I want to support projects that can't/won't generate XTCE.

@medley56 medley56 added enhancement New feature or request help wanted Extra attention is needed breaking This involves a breaking change labels Mar 28, 2024
@medley56 medley56 added this to the Version 5.0.0 Release milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This involves a breaking change enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant