Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

morning session code review #3

Open
yosefHesham opened this issue May 19, 2022 · 0 comments
Open

morning session code review #3

yosefHesham opened this issue May 19, 2022 · 0 comments

Comments

@yosefHesham
Copy link

yosefHesham commented May 19, 2022

Hello @medsonmoombe excellent work finishing that project ⭐ however, we have some issues that might need some improvements
to check the comments below:

1- it's better to use semantic tags instead of divs, i would suggest reading html best practices

2- what do you think if the sort logic is inside a separate function?

const orderScores = result.result.sort((a, b) => b.score - a.score);

and everything else is really excellent!.
please feel free to ask any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant