Use ServletContextInitializer for application initialization #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alizer, which offloads parts of the responsibilities from EntryServlet. The EntryServlet was both serving as Jersey entry point servlet, but also as handling application initialization. This is now done in the listener. The ConfigurationFactory is also throwing an exception when there is no configuration file, instead of printing to stderr and later throwing a NullPointerException. With these changes, it is easy to identify when the application fails to initialize. Which is useful when a WAR application is deployed to a platform like AWS Elastic Beanstalk. Simplify
|
Executed the tests a few times, having the following results in order: The more I executed the tests, the less failures and errors I got? Tested locally this pull request, and I could successfully serve an image, perform some rotation, zoom in, etc. |
|
This is excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This commit introduces a new
ServletContextListener,ApplicationInitializer, which offloads parts of the responsibilities fromEntryServlet. TheEntryServletwas both serving as Jersey entry point servlet, but also as handling application initialization.This is now done in the listener. The
ConfigurationFactoryis also throwing an exception when there is no configuration file, instead of printing tostderrand later throwing aNullPointerException.With these changes, it is easy to identify when the application fails to initialize. Which is useful when a WAR application is deployed to a platform like AWS Elastic Beanstalk.