feat(medusa-payment-stripe): Enhance stripe payment to handle description and improve status resolution

[adrien2p]

Allow the user to either set a static description through configuration such as:

  {
    resolve: `medusa-payment-stripe`,
    options: {
      api_key: STRIPE_API_KEY,
      webhook_secret: STRIPE_WEBHOOK_SECRET,
      payment_description: "Digital arts/services",
    },
  },

Or eventually override the static description through the cart metadata.

[ShivamJoker]

Way to go 🎉

[adrien2p]

Fixes #1401

[srindom]

@ShivamJoker @adrien2p I actually think that this is already possible if you call:

POST /carts/:id/payment-sessions/stripe
{ description: ..., [potentially more fields here]}

This call would result in:

cartService.updatePaymentSession -> paymentProviderService.updateSessionData -> StripeProvider.updatePaymentData

Where this method is implemented like this:

// [medusa-payment-stripe/.../stripe-provider.js
  async updatePaymentData(sessionData, update) {
    try {
      return this.stripe_.paymentIntents.update(sessionData.id, {
        ...update.data,
      })
    } catch (error) {
      throw error
    }
  }

[adrien2p]

@srindom if I did properly understood, the problem is that you need to create the payment intent with the description, otherwise you get an error and therefore there is nothing to update ☺️

Plus from a DX point of view, having to create and then immediately update without any changes in between I dont think it is very nice nor performant 😅 it also increase the complexity when thing can be easier to do for the consumer

Wdyt?

https://stripe.com/docs/india-accept-international-payments#paiements-internationaux-de-services

[ShivamJoker]

Ah! But still wouldn't it be easier to have a global config at least instead of updating it on cart?

[adrien2p]

@srindom any suggestion regarding the doc I linked in my comment?

[olivermrbl]

Given that descriptions are required on payments in some countries, I would argue that adding it as a configurable prop to the plugin options is reasonable.

You wrote "& other params" in the feature description @ShivamJoker - do you know of any other properties that might be worth looking into before we proceed with this one?

[ShivamJoker]

I thought for other countries we may need some more params, so I thought but for now this would do the job.

[olivermrbl]

Should we change the plugin property to payment_description to make it clear, what is actually configured?

[olivermrbl]

Would argue, that plugin options should take precedence over cart context

[adrien2p]

I wasn't sure, i was thinking that if you want to set a special description depending on the provenance of the order etc if the configuration is taking precedence it means that you can't. Wdty? The description could integrate some interesting information about the context of the payment

[adrien2p]

@olivermrbl wdty?

[ShivamJoker]

I think yeah we can do that.

[adrien2p]

Should we change the plugin property to payment_description to make it clear, what is actually configured?

Yeah agree 👍 ill do the changes asap

[adrien2p]

@olivermrbl could you point me to where I should update the doc. Only if you want it to be part of the pr

[olivermrbl]

@adrien2p did you test against the real Stripe API, that an undefined description is allowed when creating the payment intent?

[olivermrbl]

LGTM, but please address comment before merging :)