Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More than 4 cards? #64

Closed
akumanara opened this issue Oct 17, 2021 · 5 comments · Fixed by #66
Closed

More than 4 cards? #64

akumanara opened this issue Oct 17, 2021 · 5 comments · Fixed by #66

Comments

@akumanara
Copy link

As the title suggests

@medyo
Copy link
Owner

medyo commented Oct 17, 2021

Having more than 4 cards will ruin the user experience as it won't be enough space to display the data correctly.
However we can design new types of layout that are not necessarily horizontal but as a grid where you can have a bit of data of your favorite sources. something like (image)
What do you think?

@akumanara
Copy link
Author

akumanara commented Oct 17, 2021

Good idea. Is it a requirement to have all the cards in the viewport? Can we just have scrolling with more cards on bottom?

@medyo
Copy link
Owner

medyo commented Oct 31, 2021

Hi @akumanara,

Check this first version of the horizontal scroll and let me know what you think
Gif Link

@akumanara
Copy link
Author

Looks great! Do you want any help with the implementation?

@medyo medyo linked a pull request Nov 1, 2021 that will close this issue
@medyo
Copy link
Owner

medyo commented Nov 1, 2021

It's actually already implemented (should be released asap), but thanks for your help.
If you'd like to contribute in the upcoming features, you're more than welcome

@medyo medyo closed this as completed in #66 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants