Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocol errors should be handled when router locations fail #138

Closed
meejah opened this issue Oct 12, 2015 · 2 comments
Closed

protocol errors should be handled when router locations fail #138

meejah opened this issue Oct 12, 2015 · 2 comments
Labels
bug

Comments

@meejah
Copy link
Owner

meejah commented Oct 12, 2015

See this OONI bug: https://trac.torproject.org/projects/tor/ticket/17320

If txtorcon resorts to asking Tor for a GeoIP location for a router and that fails, we should "do something sensible" (like set the location to (None, None)) and handle the Failure.
@meejah meejah added the bug label Oct 12, 2015
@meejah
Copy link
Owner Author

meejah commented Oct 12, 2015

It seems this has was implemented in cad22ee included from v0.12.0 onwards. Must reconcile with the OONI problem...

@meejah
Copy link
Owner Author

meejah commented Oct 12, 2015

ooniprobe works fine with latest txtorcon as far as Tor's 551 errors -- but other things in ooni fail without the GeoIP databases available.

@meejah meejah closed this as completed Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meejah