Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "origin" property in response #184

Open
benjaminrae opened this issue Jun 2, 2023 · 1 comment
Open

Missing "origin" property in response #184

benjaminrae opened this issue Jun 2, 2023 · 1 comment

Comments

@benjaminrae
Copy link

The example response for "hello" in the docs includes the property origin.

When I make a request to https://api.dictionaryapi.dev/api/v2/entries/en/hello the response does not include the origin property.

This is the received response:

// 20230602112637
// https://api.dictionaryapi.dev/api/v2/entries/en/hello

[
  {
    "word": "hello",
    "phonetics": [
      {
        "audio": "https://api.dictionaryapi.dev/media/pronunciations/en/hello-au.mp3",
        "sourceUrl": "https://commons.wikimedia.org/w/index.php?curid=75797336",
        "license": {
          "name": "BY-SA 4.0",
          "url": "https://creativecommons.org/licenses/by-sa/4.0"
        }
      },
      {
        "text": "/həˈləʊ/",
        "audio": "https://api.dictionaryapi.dev/media/pronunciations/en/hello-uk.mp3",
        "sourceUrl": "https://commons.wikimedia.org/w/index.php?curid=9021983",
        "license": {
          "name": "BY 3.0 US",
          "url": "https://creativecommons.org/licenses/by/3.0/us"
        }
      },
      {
        "text": "/həˈloʊ/",
        "audio": ""
      }
    ],
    "meanings": [
      {
        "partOfSpeech": "noun",
        "definitions": [
          {
            "definition": "\"Hello!\" or an equivalent greeting.",
            "synonyms": [
              
            ],
            "antonyms": [
              
            ]
          }
        ],
        "synonyms": [
          "greeting"
        ],
        "antonyms": [
          
        ]
      },
      {
        "partOfSpeech": "verb",
        "definitions": [
          {
            "definition": "To greet with \"hello\".",
            "synonyms": [
              
            ],
            "antonyms": [
              
            ]
          }
        ],
        "synonyms": [
          
        ],
        "antonyms": [
          
        ]
      },
      {
        "partOfSpeech": "interjection",
        "definitions": [
          {
            "definition": "A greeting (salutation) said when meeting someone or acknowledging someone’s arrival or presence.",
            "synonyms": [
              
            ],
            "antonyms": [
              
            ],
            "example": "Hello, everyone."
          },
          {
            "definition": "A greeting used when answering the telephone.",
            "synonyms": [
              
            ],
            "antonyms": [
              
            ],
            "example": "Hello? How may I help you?"
          },
          {
            "definition": "A call for response if it is not clear if anyone is present or listening, or if a telephone conversation may have been disconnected.",
            "synonyms": [
              
            ],
            "antonyms": [
              
            ],
            "example": "Hello? Is anyone there?"
          },
          {
            "definition": "Used sarcastically to imply that the person addressed or referred to has done something the speaker or writer considers to be foolish.",
            "synonyms": [
              
            ],
            "antonyms": [
              
            ],
            "example": "You just tried to start your car with your cell phone. Hello?"
          },
          {
            "definition": "An expression of puzzlement or discovery.",
            "synonyms": [
              
            ],
            "antonyms": [
              
            ],
            "example": "Hello! What’s going on here?"
          }
        ],
        "synonyms": [
          
        ],
        "antonyms": [
          "bye",
          "goodbye"
        ]
      }
    ],
    "license": {
      "name": "CC BY-SA 3.0",
      "url": "https://creativecommons.org/licenses/by-sa/3.0"
    },
    "sourceUrls": [
      "https://en.wiktionary.org/wiki/hello"
    ]
  }
]
@yamin8000
Copy link

yamin8000 commented Aug 26, 2023

The example response for "hello" in the docs includes the property origin.

When I make a request to https://api.dictionaryapi.dev/api/v2/entries/en/hello the response does not include the origin property.
...

It is very concerning that this project doesn't have proper documentation for its API because it's a good project.
According to the source, a response may have origin but as you said, in reality, it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants